linux-kernel - Re: [PATCH v2 2/4] mm: Support tlbbatch flush for a range of PTEs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250113164809.GC14101@willie-the-truck>
Date: Mon, 13 Jan 2025 16:48:10 +0000
From: Will Deacon <will@...nel.org>
To: Barry Song <21cnbao@...il.com>
Cc: akpm@...ux-foundation.org, linux-mm@...ck.org,
	baolin.wang@...ux.alibaba.com, chrisl@...nel.org, david@...hat.com,
	ioworker0@...il.com, kasong@...cent.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	ryan.roberts@....com, v-songbaohua@...o.com, x86@...nel.org,
	linux-riscv@...ts.infradead.org, ying.huang@...el.com,
	zhengtangquan@...o.com, lorenzo.stoakes@...cle.com,
	Catalin Marinas <catalin.marinas@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Anshuman Khandual <anshuman.khandual@....com>,
	Shaoqin Huang <shahuang@...hat.com>, Gavin Shan <gshan@...hat.com>,
	Kefeng Wang <wangkefeng.wang@...wei.com>,
	Mark Rutland <mark.rutland@....com>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Yosry Ahmed <yosryahmed@...gle.com>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>,
	Yicong Yang <yangyicong@...ilicon.com>
Subject: Re: [PATCH v2 2/4] mm: Support tlbbatch flush for a range of PTEs

On Mon, Jan 13, 2025 at 04:38:59PM +1300, Barry Song wrote:
> From: Barry Song <v-songbaohua@...o.com>
> 
> This is a preparatory patch to support batch PTE unmapping in
> `try_to_unmap_one`. It first introduces range handling for
> `tlbbatch` flush. Currently, the range is always set to the size of
> PAGE_SIZE.
> 
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will@...nel.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: Anshuman Khandual <anshuman.khandual@....com>
> Cc: Ryan Roberts <ryan.roberts@....com>
> Cc: Shaoqin Huang <shahuang@...hat.com>
> Cc: Gavin Shan <gshan@...hat.com>
> Cc: Kefeng Wang <wangkefeng.wang@...wei.com>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: David Hildenbrand <david@...hat.com>
> Cc: Lance Yang <ioworker0@...il.com>
> Cc: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
> Cc: Yosry Ahmed <yosryahmed@...gle.com>
> Cc: Paul Walmsley <paul.walmsley@...ive.com>
> Cc: Palmer Dabbelt <palmer@...belt.com>
> Cc: Albert Ou <aou@...s.berkeley.edu>
> Cc: Yicong Yang <yangyicong@...ilicon.com>
> Signed-off-by: Barry Song <v-songbaohua@...o.com>
> ---
>  arch/arm64/include/asm/tlbflush.h | 26 ++++++++++++++------------
>  arch/arm64/mm/contpte.c           |  2 +-
>  arch/riscv/include/asm/tlbflush.h |  3 ++-
>  arch/riscv/mm/tlbflush.c          |  3 ++-
>  arch/x86/include/asm/tlbflush.h   |  3 ++-
>  mm/rmap.c                         | 12 +++++++-----
>  6 files changed, 28 insertions(+), 21 deletions(-)

The arm64 bits look correct to me:

Acked-by: Will Deacon <will@...nel.org>

Will