linux-kernel - Re: [PATCH v5] hwmon: (pwm-fan): Default to the Maximum cooling level if provided

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7bad4087-5ad1-448e-ac9f-c298a66052d8@roeck-us.net>
Date: Mon, 13 Jan 2025 08:56:36 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Peter Korsgaard <peter@...sgaard.com>
Cc: linux-hwmon@...r.kernel.org, Jean Delvare <jdelvare@...e.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5] hwmon: (pwm-fan): Default to the Maximum cooling
 level if provided

On Mon, Jan 13, 2025 at 02:51:18PM +0100, Peter Korsgaard wrote:
> The pwm-fan driver uses full PWM (255) duty cycle at startup, which may not
> always be desirable because of noise or power consumption peaks.
> 
> The driver optionally accept a list of "cooling-levels" for the thermal
> subsystem.  If provided, use the PWM value corresponding to the maximum
> cooling level rather than the full level as the initial PWM setting.
> 
> Signed-off-by: Peter Korsgaard <peter@...sgaard.com>

Applied, after

> +	ret = pwm_fan_get_cooling_data(dev, ctx);
> +	if (ret)
> +		return ret;
> +
> +

dropping this double empty line.

Guenter