linux-kernel - Re: [PATCH v2 0/5] KVM: kvm_set_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D714H3L41ZMM.1R3UEQ00HD8XG@linux.ibm.com>
Date: Mon, 13 Jan 2025 18:30:43 +0100
From: "Christoph Schlameuss" <schlameuss@...ux.ibm.com>
To: "Sean Christopherson" <seanjc@...gle.com>,
        "Paolo Bonzini"
 <pbonzini@...hat.com>
Cc: <kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        "Tao Su"
 <tao1.su@...ux.intel.com>,
        "Claudio Imbrenda" <imbrenda@...ux.ibm.com>,
        "Christian Borntraeger" <borntraeger@...ibm.com>,
        "Xiaoyao Li"
 <xiaoyao.li@...el.com>
Subject: Re: [PATCH v2 0/5] KVM: kvm_set_memory_region() cleanups

On Sat Jan 11, 2025 at 1:20 AM CET, Sean Christopherson wrote:
> Cleanups related to kvm_set_memory_region(), salvaged from similar patches
> that were flying around when we were sorting out KVM_SET_USER_MEMORY_REGION2.
>
> And, hopefully, the KVM-internal memslots hardening will also be useful for
> s390's ucontrol stuff (https://lore.kernel.org/all/Z4FJNJ3UND8LSJZz@google.com).

Whole series:

Acked-by: Christoph Schlameuss <schlameuss@...ux.ibm.com>

>
> v2:
>  - Keep check_memory_region_flags() where it is. [Xiaoyao]
>  - Rework the changelog for the last patch to account for the change in
>    motiviation.
>  - Fix double spaces goofs. [Tao]
>  - Add a lockdep assertion in the x86 code, too. [Tao]
>
> v1: https://lore.kernel.org/all/20240802205003.353672-1-seanjc@google.com
>
> Sean Christopherson (5):
>   KVM: Open code kvm_set_memory_region() into its sole caller (ioctl()
>     API)
>   KVM: Assert slots_lock is held when setting memory regions
>   KVM: Add a dedicated API for setting KVM-internal memslots
>   KVM: x86: Drop double-underscores from __kvm_set_memory_region()
>   KVM: Disallow all flags for KVM-internal memslots
>
>  arch/x86/kvm/x86.c       |  7 ++++---
>  include/linux/kvm_host.h |  8 +++-----
>  virt/kvm/kvm_main.c      | 33 ++++++++++++++-------------------
>  3 files changed, 21 insertions(+), 27 deletions(-)
>
>
> base-commit: 10b2c8a67c4b8ec15f9d07d177f63b563418e948