[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CABTCjFCaTOLQQ_cU10HNiVUoWT=FreoKYj3yAGQYccDkagcn0g@mail.gmail.com>
Date: Mon, 13 Jan 2025 20:42:27 +0300
From: Dzmitry Sankouski <dsankouski@...il.com>
To: Lee Jones <lee@...nel.org>
Cc: Sebastian Reichel <sre@...nel.org>, Chanwoo Choi <cw00.choi@...sung.com>,
Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Dmitry Torokhov <dmitry.torokhov@...il.com>, Pavel Machek <pavel@....cz>,
Hans de Goede <hdegoede@...hat.com>, Marek Szyprowski <m.szyprowski@...sung.com>,
Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>, Purism Kernel Team <kernel@...i.sm>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, linux-input@...r.kernel.org,
linux-leds@...r.kernel.org
Subject: Re: [PATCH v14 08/10] mfd: Add new driver for MAX77705 PMIC
чт, 9 янв. 2025 г. в 15:21, Lee Jones <lee@...nel.org>:
>
> On Wed, 08 Jan 2025, Dzmitry Sankouski wrote:
>
> > Add the core MFD driver for max77705 PMIC. Drivers for sub-devices
> > will be added in subsequent patches.
> >
> > Signed-off-by: Dzmitry Sankouski <dsankouski@...il.com>
> >
(...)
> > +
> > + /* Unmask interrupts from all blocks in interrupt source register */
> > + ret = regmap_update_bits(max77705->regmap,
> > + MAX77705_PMIC_REG_INTSRC_MASK,
> > + MAX77705_SRC_IRQ_ALL, (unsigned int)~MAX77705_SRC_IRQ_ALL);
>
> I don't see this much. Are you sure the cast is required?
>
BIT macro creates a 64 bit constant value. When inverted,
it overruns 32 bit value, causing compiler to warn on conversion like
`warning: conversion from ‘long unsigned int’ to ‘unsigned int’`.
--
Best regards and thanks for review,
Dzmitry
Powered by blists - more mailing lists