linux-kernel - Re: [PATCH] fs: debugfs: fix open proxy for unsafe files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <555bb228-ac49-43a4-b1cf-1d163b053973@linux.vnet.ibm.com>
Date: Mon, 13 Jan 2025 11:04:48 +0530
From: Venkat Rao Bagalkote <venkat88@...ux.vnet.ibm.com>
To: Johannes Berg <johannes@...solutions.net>, linux-kernel@...r.kernel.org
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Johannes Berg <johannes.berg@...el.com>,
        Suresh Kumar Kurmi <suresh.kumar.kurmi@...el.com>,
        kernel test robot <oliver.sang@...el.com>
Subject: Re: [PATCH] fs: debugfs: fix open proxy for unsafe files

Applied and Verified the below patch. Proposed fix works fine.

Please add below tag.

Tested-by: Venkat Rao Bagalkote <venkat88@...ux.vnet.ibm.com>

Regards,
Venkat.


On 10/01/25 1:28 pm, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@...el.com>
>
> In the previous commit referenced below, I had to split
> the short fops handling into different proxy fops. This
> necessitated knowing out-of-band whether or not the ops
> are short or full, when attempting to convert from fops
> to allocated fsdata.
>
> Unfortunately, I only converted full_proxy_open() which
> is used for the new full_proxy_open_regular() and
> full_proxy_open_short(), but forgot about the call in
> open_proxy_open(), used for debugfs_create_file_unsafe().
>
> Fix that, it never has short fops.
>
> Fixes: f8f25893a477 ("fs: debugfs: differentiate short fops with proxy ops")
> Reported-by: Suresh Kumar Kurmi <suresh.kumar.kurmi@...el.com>
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Closes: https://lore.kernel.org/oe-lkp/202501101055.bb8bf3e7-lkp@intel.com
> Reported-by: Venkat Rao Bagalkote <venkat88@...ux.vnet.ibm.com>
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>
> ---
>   fs/debugfs/file.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
> index bdb4f2ca0506..16e198a26339 100644
> --- a/fs/debugfs/file.c
> +++ b/fs/debugfs/file.c
> @@ -280,7 +280,7 @@ static int open_proxy_open(struct inode *inode, struct file *filp)
>   	const struct file_operations *real_fops = NULL;
>   	int r;
>   
> -	r = debugfs_file_get(dentry);
> +	r = __debugfs_file_get(dentry, DBGFS_GET_REGULAR);
>   	if (r)
>   		return r == -EIO ? -ENOENT : r;
>