linux-kernel - Re: [PATCH 04/10] wifi: ath12k: fix firmware assert during reboot with hardware grouping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5925d874-1b8c-413a-a6ad-16d7ab299f4e@oss.qualcomm.com>
Date: Mon, 13 Jan 2025 11:12:57 -0800
From: Jeff Johnson <jeff.johnson@....qualcomm.com>
To: Aditya Kumar Singh <quic_adisi@...cinc.com>,
        Kalle Valo
 <kvalo@...nel.org>, Jeff Johnson <jjohnson@...nel.org>,
        Karthikeyan Periyasamy <quic_periyasa@...cinc.com>,
        Harshitha Prem <quic_hprem@...cinc.com>
Cc: Kalle Valo <quic_kvalo@...cinc.com>, linux-wireless@...r.kernel.org,
        ath12k@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/10] wifi: ath12k: fix firmware assert during reboot
 with hardware grouping

On 1/8/2025 8:25 PM, Aditya Kumar Singh wrote:
> At present, during PCI shutdown, the power down is only executed for a
> single device. However, when operating in a group, all devices need to be
> powered down simultaneously. Failure to do so will result in a firmware
> assertion.
> 
> Hence, introduce a new ath12k_pci_hw_group_power_down() and call it during
> power down. This will ensure that all partner devices are properly powered
> down.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Aditya Kumar Singh <quic_adisi@...cinc.com>
> ---
>  drivers/net/wireless/ath/ath12k/pci.c | 23 ++++++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/pci.c b/drivers/net/wireless/ath/ath12k/pci.c
> index 837be309cd45a2d037ee8c3bba8f7be0f457d6b2..7f6521a56ffc0f1e9687c94d6829a9c1f1887661 100644
> --- a/drivers/net/wireless/ath/ath12k/pci.c
> +++ b/drivers/net/wireless/ath/ath12k/pci.c
> @@ -1751,13 +1751,34 @@ static void ath12k_pci_remove(struct pci_dev *pdev)
>  	ath12k_core_free(ab);
>  }
>  
> +static void ath12k_pci_hw_group_power_down(struct ath12k_hw_group *ag)

don't you end up calling this for every device in the group?
what prevents ath12k_pci_power_down(ab, false) from being called multiple
times for the same ab?

> +{
> +	struct ath12k_base *ab;
> +	int i;
> +
> +	if (!ag)
> +		return;
> +
> +	mutex_lock(&ag->mutex);
> +
> +	for (i = 0; i < ag->num_devices; i++) {
> +		ab = ag->ab[i];
> +		if (!ab)
> +			continue;
> +
> +		ath12k_pci_power_down(ab, false);
> +	}
> +
> +	mutex_unlock(&ag->mutex);
> +}
> +
>  static void ath12k_pci_shutdown(struct pci_dev *pdev)
>  {
>  	struct ath12k_base *ab = pci_get_drvdata(pdev);
>  	struct ath12k_pci *ab_pci = ath12k_pci_priv(ab);
>  
>  	ath12k_pci_set_irq_affinity_hint(ab_pci, NULL);
> -	ath12k_pci_power_down(ab, false);
> +	ath12k_pci_hw_group_power_down(ab->ag);
>  }
>  
>  static __maybe_unused int ath12k_pci_pm_suspend(struct device *dev)
>