linux-kernel - Re: [PATCH] spmi: Fix controller->node != parent->node breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e4feb21891b899a189fe51362bba7f89.sboyd@kernel.org>
Date: Mon, 13 Jan 2025 11:16:41 -0800
From: Stephen Boyd <sboyd@...nel.org>
To: Joe Hattori <joe@...is.s.u-tokyo.ac.jp>, Konrad Dybcio <konradybcio@...nel.org>, Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc: Marijn Suijten <marijn.suijten@...ainline.org>, linux-kernel@...r.kernel.org, Bjorn Andersson <bjorn.andersson@....qualcomm.com>, Abel Vesa <abel.vesa@...aro.org>, Johan Hovold <johan+linaro@...nel.org>, Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH] spmi: Fix controller->node != parent->node breakage

Quoting Konrad Dybcio (2025-01-11 03:21:00)
> From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> 
> On some platforms, like recent Qualcomm SoCs with multi-bus SPMI
> arbiters, controller->node must be assigned to the individual buses'
> subnodes, as the slave devices are children of these, like so:
> 
> arbiter@...0000
>         spmi@...d000
>                 pmic@0
> 
>         spmi@...2000
>                 pmic@0
> 
> The commit referenced in Fixes changed that assignment, such that
> spmi_controller_alloc() always assumes the PMICs come directly under
> the arbiter node (which is true when there's only a single bus per
> controller).
> 
> Make controller->node specifiable to both benefit from Joe's refcount
> improvements and un-break the aforementioned platforms.
> 
> Fixes: 821b07853e32 ("spmi: hisi-spmi-controller: manage the OF node reference in device initialization and cleanup")

I'll drop that patch. It sounds like it's not ready.

> Signed-off-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>