linux-kernel - Re: [PATCH v1] iio: adc: pac1921: Move ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcyVsZ=Q3d0i7YWGgZms8bSokcQgDKs1U0h=RsSVxanAw@mail.gmail.com>
Date: Mon, 13 Jan 2025 21:23:23 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: victor.duicu@...rochip.com
Cc: matteomartelli3@...il.com, jic23@...nel.org, lars@...afoo.de, 
	marius.cristea@...rochip.com, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] iio: adc: pac1921: Move ACPI_FREE to cover all branches

On Mon, Jan 13, 2025 at 3:25 PM <victor.duicu@...rochip.com> wrote:
>
> From: Victor Duicu <victor.duicu@...rochip.com>
>
> This patch moves ACPI_FREE in pac1921_match_acpi_device

ACPI_FREE()
pac1921_match_acpi_device()

> in order to cover all branches.

Do we need a Fixes tag?

...

> +       ACPI_FREE(status);
> +

Not sure if we need this blank line.

>         if (!label)
>                 return -ENOMEM;

...

Other than above, LGTM, thanks for addressing it.

-- 
With Best Regards,
Andy Shevchenko