linux-kernel - Re: [PATCH net-next 0/3] virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPpAL=zaZ+7judG424sEmndE2UxEFA0ZdcEB7tB1A3PcGw5n9A@mail.gmail.com>
Date: Mon, 13 Jan 2025 14:03:08 +0800
From: Lei Yang <leiyang@...hat.com>
To: Joe Damato <jdamato@...tly.com>
Cc: netdev@...r.kernel.org, mkarsten@...terloo.ca, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Eugenio Pérez <eperezma@...hat.com>, 
	Jakub Kicinski <kuba@...nel.org>, Jason Wang <jasowang@...hat.com>, 
	open list <linux-kernel@...r.kernel.org>, "Michael S. Tsirkin" <mst@...hat.com>, 
	Paolo Abeni <pabeni@...hat.com>, 
	"open list:VIRTIO CORE AND NET DRIVERS" <virtualization@...ts.linux.dev>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Subject: Re: [PATCH net-next 0/3] virtio_net: Link queues to NAPIs

I tested this series of patches with virtio-net regression tests,
everything works fine.

Tested-by: Lei Yang <leiyang@...hat.com>


On Sat, Jan 11, 2025 at 4:26 AM Joe Damato <jdamato@...tly.com> wrote:
>
> Greetings:
>
> Recently [1], Jakub mentioned that there were a few drivers that are not
> yet mapping queues to NAPIs.
>
> While I don't have any of the other hardware mentioned, I do happen to
> have a virtio_net laying around ;)
>
> I've attempted to link queues to NAPIs, taking care to hold RTNL when it
> seemed that the path was not already holding it.
>
> Note: It seems virtio_net uses TX-only NAPIs which do not have NAPI IDs.
> As such, I've left the TX NAPIs unset (as opposed to setting them to 0).
>
> See the commit message of patch 3 for example out to see what I mean.
>
> Thanks,
> Joe
>
> [1]: https://lore.kernel.org/netdev/20250109084301.2445a3e3@kernel.org/
>
> Joe Damato (3):
>   virtio_net: Prepare for NAPI to queue mapping
>   virtio_net: Hold RTNL for NAPI to queue mapping
>   virtio_net: Map NAPIs to queues
>
>  drivers/net/virtio_net.c | 48 ++++++++++++++++++++++++++++++++++++----
>  1 file changed, 44 insertions(+), 4 deletions(-)
>
>
> base-commit: 7b24f164cf005b9649138ef6de94aaac49c9f3d1
> --
> 2.25.1
>
>