linux-kernel - Re: [RESEND v7 2/3] x86: probe memory block size advisement value during mm init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67857e1234ada_1863f3294a1@iweiny-mobl.notmuch>
Date: Mon, 13 Jan 2025 14:56:50 -0600
From: Ira Weiny <ira.weiny@...el.com>
To: Gregory Price <gourry@...rry.net>, <linux-mm@...ck.org>,
	<linux-acpi@...r.kernel.org>
CC: <kernel-team@...a.com>, <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<dave.hansen@...ux.intel.com>, <luto@...nel.org>, <peterz@...radead.org>,
	<tglx@...utronix.de>, <mingo@...hat.com>, <bp@...en8.de>, <hpa@...or.com>,
	<rafael@...nel.org>, <lenb@...nel.org>, <david@...hat.com>,
	<osalvador@...e.de>, <gregkh@...uxfoundation.org>,
	<akpm@...ux-foundation.org>, <dan.j.williams@...el.com>,
	<Jonathan.Cameron@...wei.com>, <alison.schofield@...el.com>,
	<rrichter@....com>, <rppt@...nel.org>, <gourry@...rry.net>,
	<bfaccini@...dia.com>, <haibo1.xu@...el.com>, <dave.jiang@...el.com>, Fan Ni
	<fan.ni@...sung.com>
Subject: Re: [RESEND v7 2/3] x86: probe memory block size advisement value
 during mm init

Gregory Price wrote:
> Systems with hotplug may provide an advisement value on what the
> memblock size should be.  Probe this value when the rest of the
> configuration values are considered.
> 
> The new heuristic is as follows
> 
> 1) set_memory_block_size_order value if already set (cmdline param)
> 2) minimum block size if memory is less than large block limit
> 3) if no hotplug advice: Max block size if system is bare-metal,
>    otherwise use end of memory alignment.
> 4) if hotplug advice: lesser of advice and end of memory alignment.
> 
> Convert to cpu_feature_enabled() while at it.[1]
> 
> [1] https://lore.kernel.org/all/20241031103401.GBZyNdGQ-ZyXKyzC_z@fat_crate.local/
> 
> Suggested-by: Borislav Petkov <bp@...en8.de>
> Suggested-by: David Hildenbrand <david@...hat.com>
> Signed-off-by: Gregory Price <gourry@...rry.net>
> Acked-by: David Hildenbrand <david@...hat.com>
> Acked-by: Dave Hansen <dave.hansen@...ux.intel.com>
> Acked-by: Mike Rapoport (Microsoft) <rppt@...nel.org>
> Acked-by: Dan Williams <dan.j.williams@...el.com>
> Tested-by: Fan Ni <fan.ni@...sung.com>

Reviewed-by: Ira Weiny <ira.weiny@...el.com>

[snip]