linux-kernel - Re: [PATCH v5 2/4] dt-bindings: clock: drop NUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b60a7a7775b6bae58d231a52bd9ef10.sboyd@kernel.org>
Date: Mon, 13 Jan 2025 13:53:46 -0800
From: Stephen Boyd <sboyd@...nel.org>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Michael Turquette <mturquette@...libre.com>, Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, upstream@...oha.com, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v5 2/4] dt-bindings: clock: drop NUM_CLOCKS define for EN7581

Quoting Christian Marangi (2025-01-13 13:37:56)
> On Mon, Jan 13, 2025 at 01:33:35PM -0800, Stephen Boyd wrote:
> > Subject says EN7581....
> > 
> > Quoting Christian Marangi (2025-01-12 05:39:38)
> > > Drop NUM_CLOCKS define for EN7581 include. This is not a binding and
> > > should not be placed here. Value is derived internally in the user
> > > driver.
> > > 
> > > Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > > ---
> > > Changes v5:
> > > - Add ack tag
> > > Changes v4:
> > > - Move to patch 2 (improves bisectability)
> > > Changes v3:
> > > - Add this patch
> > > 
> > >  include/dt-bindings/clock/en7523-clk.h | 2 --
> > >  1 file changed, 2 deletions(-)
> > > 
> > > diff --git a/include/dt-bindings/clock/en7523-clk.h b/include/dt-bindings/clock/en7523-clk.h
> > > index 717d23a5e5ae..28e56745ccff 100644
> > > --- a/include/dt-bindings/clock/en7523-clk.h
> > > +++ b/include/dt-bindings/clock/en7523-clk.h
> > > @@ -12,6 +12,4 @@
> > >  #define EN7523_CLK_CRYPTO      6
> > >  #define EN7523_CLK_PCIE                7
> > >  
> > > -#define EN7523_NUM_CLOCKS      8
> > 
> > But this is EN7523
> > 
> > drivers/clk/clk-en7523.c:539:25: error: ‘EN7523_NUM_CLOCKS’ undeclared (first use in this function)
> >   539 |         clk_data->num = EN7523_NUM_CLOCKS;
> >       |                         ^~~~~~~~~~~~~~~~~
> 
> Hi Stephen,
> 
> the same define is used for both EN7523 and EN7581, do you want me to resubmit with a
> better description?
> 
> Both clock are updated so no regression.
> 

Please resubmit the entire patchset. It doesn't compile.