linux-kernel - Re: [PATCH v2] io_uring: simplify the SQPOLL thread check when cancelling requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173680740642.1193220.11121663333496197972.b4-ty@kernel.dk>
Date: Mon, 13 Jan 2025 15:30:06 -0700
From: Jens Axboe <axboe@...nel.dk>
To: linux-kernel@...r.kernel.org, Bui Quang Minh <minhquangbui99@...il.com>
Cc: Pavel Begunkov <asml.silence@...il.com>, io-uring@...r.kernel.org, 
 syzbot+3c750be01dab672c513d@...kaller.appspotmail.com, 
 Li Zetao <lizetao1@...wei.com>
Subject: Re: [PATCH v2] io_uring: simplify the SQPOLL thread check when
 cancelling requests


On Mon, 13 Jan 2025 23:03:31 +0700, Bui Quang Minh wrote:
> In io_uring_try_cancel_requests, we check whether sq_data->thread ==
> current to determine if the function is called by the SQPOLL thread to do
> iopoll when IORING_SETUP_SQPOLL is set. This check can race with the SQPOLL
> thread termination.
> 
> io_uring_cancel_generic is used in 2 places: io_uring_cancel_generic and
> io_ring_exit_work. In io_uring_cancel_generic, we have the information
> whether the current is SQPOLL thread already. And the SQPOLL thread never
> reaches io_ring_exit_work.
> 
> [...]

Applied, thanks!

[1/1] io_uring: simplify the SQPOLL thread check when cancelling requests
      commit: a13030fd194c88961be4679f87a1380f1bda0ebe

Best regards,
-- 
Jens Axboe