linux-kernel - Re: [PATCH] rseq/selftests: Fix riscv rseq_offset_deref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3bcdf139-81e2-4ef3-8e86-1e22b4df6d49@linuxfoundation.org>
Date: Mon, 13 Jan 2025 15:59:24 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Stafford Horne <shorne@...il.com>, LKML <linux-kernel@...r.kernel.org>
Cc: Peter Zijlstra <peterz@...radead.org>,
 "Paul E. McKenney" <paulmck@...nel.org>, Boqun Feng <boqun.feng@...il.com>,
 Shuah Khan <shuah@...nel.org>, Paul Walmsley <paul.walmsley@...ive.com>,
 Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 linux-kselftest@...r.kernel.org, linux-riscv@...ts.infradead.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] rseq/selftests: Fix riscv rseq_offset_deref_addv inline
 asm

On 1/10/25 09:22, Mathieu Desnoyers wrote:
> On 2025-01-02 23:03, Stafford Horne wrote:
>> When working on OpenRISC support for restartable sequences I noticed
>> and fixed these two issues with the riscv support bits.
>>
>>   1 The 'inc' argument to RSEQ_ASM_OP_R_DEREF_ADDV was being implicitly
>>     passed to the macro.  Fix this by adding 'inc' to the list of macro
>>     arguments.
>>   2 The inline asm input constraints for 'inc' and 'off' use "er",  The
>>     riscv gcc port does not have an "e" constraint, this looks to be
>>     copied from the x86 port.  Fix this by just using an "r" constraint.
>>
>> I have compile tested this only for riscv.  However, the same fixes I
>> use in the OpenRISC rseq selftests and everything passes with no issues.
>>
>> Signed-off-by: Stafford Horne <shorne@...il.com>
> 
> Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
> 

If these are going through risc repo

Acked-by: Shuah Khan <skhan@...uxfoundation.org>

If you would like me to take this, let me know.

thanks,
-- Shuah