linux-kernel - RE: [PATCH next] HID: intel-thc-hid: intel-thc: Fix error code in thc_i2c_subip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6098C9EB3E69BDEDA8889BE9F41F2@IA1PR11MB6098.namprd11.prod.outlook.com>
Date: Mon, 13 Jan 2025 06:42:45 +0000
From: "Xu, Even" <even.xu@...el.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: "Sun, Xinpeng" <xinpeng.sun@...el.com>, Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <bentiss@...nel.org>, Mark Pearson
	<mpearson-lenovo@...ebb.ca>, Srinivas Pandruvada
	<srinivas.pandruvada@...ux.intel.com>, "linux-input@...r.kernel.org"
	<linux-input@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH next] HID: intel-thc-hid: intel-thc: Fix error code in
 thc_i2c_subip_init()


> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@...aro.org>
> Sent: Monday, January 13, 2025 2:16 PM
> To: Xu, Even <even.xu@...el.com>
> Cc: Sun, Xinpeng <xinpeng.sun@...el.com>; Jiri Kosina <jikos@...nel.org>;
> Benjamin Tissoires <bentiss@...nel.org>; Mark Pearson <mpearson-
> lenovo@...ebb.ca>; Srinivas Pandruvada
> <srinivas.pandruvada@...ux.intel.com>; linux-input@...r.kernel.org; linux-
> kernel@...r.kernel.org; kernel-janitors@...r.kernel.org
> Subject: [PATCH next] HID: intel-thc-hid: intel-thc: Fix error code in
> thc_i2c_subip_init()
> 
> Return -ENOMEM if the allocation fails.  Don't return success.
> 
> Fixes: 4228966def88 ("HID: intel-thc-hid: intel-thc: Add THC I2C config
> interfaces")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c b/drivers/hid/intel-
> thc-hid/intel-thc/intel-thc-dev.c
> index 92a1dbe9a928..4fc78b5a04b5 100644
> --- a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c
> +++ b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c
> @@ -1519,7 +1519,7 @@ int thc_i2c_subip_init(struct thc_device *dev, const
> u32 target_address,
> 
>  	dev->i2c_subip_regs = devm_kzalloc(dev->dev, sizeof(i2c_subip_regs),
> GFP_KERNEL);
>  	if (!dev->i2c_subip_regs)
> -		return PTR_ERR(dev->i2c_subip_regs);
> +		return -ENOMEM;
> 

Looks reasonable.
Thanks Dan!

Best Regards,
Even Xu

>  	return 0;
>  }
> --
> 2.45.2