linux-kernel - Re: [PATCH v4 13/14] of/fdt: Check fdt_get_mem_rsv() error in early_init_fdt_scan_reserved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <173681115175.3630879.12415941975692508036.robh@kernel.org>
Date: Mon, 13 Jan 2025 17:32:33 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Zijun Hu <zijun_hu@...oud.com>
Cc: Catalin Marinas <catalin.marinas@....com>,
	Mike Rapoport <rppt@...nel.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Maxime Ripard <mripard@...nel.org>,
	Andreas Herrmann <andreas.herrmann@...xeda.com>,
	Marc Zyngier <maz@...nel.org>, Robin Murphy <robin.murphy@....com>,
	linux-kernel@...r.kernel.org,
	Saravana Kannan <saravanak@...gle.com>,
	Oreoluwa Babatunde <quic_obabatun@...cinc.com>,
	Zijun Hu <quic_zijuhu@...cinc.com>, devicetree@...r.kernel.org
Subject: Re: [PATCH v4 13/14] of/fdt: Check fdt_get_mem_rsv() error in
 early_init_fdt_scan_reserved_mem()


On Thu, 09 Jan 2025 21:27:04 +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@...cinc.com>
> 
> early_init_fdt_scan_reserved_mem() invoks fdt_get_mem_rsv(), and it will
> use uninitialized variables @base and @size once the callee suffers error.
> 
> Fix by checking fdt_get_mem_rsv() error as other callers do.
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
> ---
>  drivers/of/fdt.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 

Applied, thanks!