linux-kernel - Re: [PATCH v4 4/6] dt-bindings: iio: Add adis16550 bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <y54kfnkbuugvsgfzufhk3mmwmmzbko47fg3jxw36sefzxaxcz6@znigvgdcljeq>
Date: Mon, 13 Jan 2025 09:43:34 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Robert Budai <robert.budai@...log.com>
Cc: Nuno Sa <nuno.sa@...log.com>, 
	Ramona Gradinariu <ramona.gradinariu@...log.com>, Antoniu Miclaus <antoniu.miclaus@...log.com>, 
	Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, 
	Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Jonathan Corbet <corbet@....net>, Alex Lanzano <lanzano.alex@...il.com>, linux-iio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v4 4/6] dt-bindings: iio: Add adis16550 bindings

On Fri, Jan 10, 2025 at 09:42:52AM +0200, Robert Budai wrote:
> +maintainers:
> +  - Nuno Sa <nuno.sa@...log.com>
> +  - Ramona Gradinariu <ramona.gradinariu@...log.com>
> +  - Antoniu Miclaus <antoniu.miclaus@...log.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - adi,adis16550
> +      - adi,adis16550w

Where is the answer for my questions at v1? No responses on email,
nothing improved in the patchset. Go back to my comments and respond to
them or implement them.


> +
> +  reg:
> +    maxItems: 1
> +
> +  spi-cpha: true
> +
> +  spi-cpol: true
> +
> +  spi-max-frequency:
> +    maximum: 15000000
> +
> +  vdd-supply: true
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reset-gpios:
> +    description:
> +      RESET active low pin.
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +    description: If not provided, then the internal clock is used.
> +
> +  adi,sync-mode:
> +    description:
> +      Configures the device SYNC pin. The following modes are supported
> +      0 - output_sync
> +      1 - direct_sync
> +      2 - scaled_sync
> +      3 - pulse_sync
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 1
> +    maximum: 2

So what does the "3" mean? Why documenting something impossible?

Anyway, use strings for these and drop "_sync" suffixes.

Best regards,
Krzysztof