linux-kernel - Re: [PATCH] pwm/mtk-disp: change mm clock as optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <99526d14-7c54-44a0-8549-832077d1b418@collabora.com>
Date: Mon, 13 Jan 2025 09:51:16 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Bincai Liu <bincai.liu@...iatek.com>, thierry.reding@...il.com,
 ukleinek@...nel.org, u.kleine-koenig@...gutronix.de, matthias.bgg@...il.com
Cc: devicetree@...r.kernel.org, linux-pwm@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org,
 Project_Global_Chrome_Upstream_Group@...iatek.com, jitao.shi@...iatek.com
Subject: Re: [PATCH] pwm/mtk-disp: change mm clock as optional

Il 13/01/25 07:15, Bincai Liu ha scritto:
> mt8196 doesn't have mm clock. Make this clock optional for mt8196.
> 

This commit is okay, but you have to reflect that change in the bindings as well,
otherwise you get validation errors in devicetrees.

Cheers,
Angelo

> Signed-off-by: Bincai Liu <bincai.liu@...iatek.com>
> ---
>   drivers/pwm/pwm-mtk-disp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pwm/pwm-mtk-disp.c b/drivers/pwm/pwm-mtk-disp.c
> index bafd6b6195f6..ad7928cd607f 100644
> --- a/drivers/pwm/pwm-mtk-disp.c
> +++ b/drivers/pwm/pwm-mtk-disp.c
> @@ -250,7 +250,7 @@ static int mtk_disp_pwm_probe(struct platform_device *pdev)
>   		return dev_err_probe(&pdev->dev, PTR_ERR(mdp->clk_main),
>   				     "Failed to get main clock\n");
>   
> -	mdp->clk_mm = devm_clk_get(&pdev->dev, "mm");
> +	mdp->clk_mm = devm_clk_get_optional(&pdev->dev, "mm");
>   	if (IS_ERR(mdp->clk_mm))
>   		return dev_err_probe(&pdev->dev, PTR_ERR(mdp->clk_mm),
>   				     "Failed to get mm clock\n");