linux-kernel - Re: [PATCH 2/2] dt-bindings: serial: Add a new compatible string for ums9632

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB9BWhdAQS5f2OpH8-PZXCWtWWybPJ+UaLvQNu4UacPF_sCg2A@mail.gmail.com>
Date: Mon, 13 Jan 2025 10:29:58 +0800
From: wenhua lin <wenhua.lin1994@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Stanislav Jakubek <stano.jakubek@...il.com>, wenhua.lin@...soc.com, Zhaochen.Su@...soc.com, 
	Zhirong.Qiu@...soc.com, baolin.wang@...ux.alibaba.com, brgl@...ev.pl, 
	cixi.geng@...ux.dev, conor+dt@...nel.org, devicetree@...r.kernel.org, 
	gregkh@...uxfoundation.org, jirislaby@...nel.org, krzk+dt@...nel.org, 
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, 
	orsonzhai@...il.com, robh@...nel.org, xiongpeng.wu@...soc.com, 
	zhang.lyra@...il.com
Subject: Re: [PATCH 2/2] dt-bindings: serial: Add a new compatible string for ums9632

On Thu, Nov 21, 2024 at 9:34 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 21/11/2024 13:26, Stanislav Jakubek wrote:
> > Correct me if I'm wrong, but this patch seems incorrect to me.
> > The 1st patch suggets that the sc9632-uart is incompatible with sc9836-uart,
> > but here you make it fallback to it anyway.
> >
> > Also, both of the patches seem to have made it to linux-next without the
> > reviews/Acks from maintainers. Maybe Greg was a bit too fast here :)
>
> Yeah, this looks odd and considering totally empty commit msg (nothing
> useful there), it looks like wrong choice.
>
> Please explain the compatibility aspects. In the future: you have entire
> commit msg to describe the hardware, instead of repeating the obvious -
> what is visible from the diff.
>
> Best regards,
> Krzysztof

Hi Krzysztof:
   Thank you very much for your review, we will correct it in patch v2.
Thanks