linux-kernel - Re: [PATCH] pinctrl: mediatek: Add support for MT8196

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f2c9274bc3078024f378a263c703f1a65ae7a74d.camel@mediatek.com>
Date: Mon, 13 Jan 2025 10:03:12 +0000
From: Cathy Xu (许华婷) <ot_cathy.xu@...iatek.com>
To: "christophe.jaillet@...adoo.fr" <christophe.jaillet@...adoo.fr>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "linus.walleij@...aro.org"
	<linus.walleij@...aro.org>, "sean.wang@...nel.org" <sean.wang@...nel.org>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>,
	Guodong Liu (刘国栋) <Guodong.Liu@...iatek.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: mediatek: Add support for MT8196

On Mon, 2024-11-11 at 10:12 +0100, Christophe JAILLET wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Le 11/11/2024 à 09:53, ot907280 a écrit :
> > From: Guodong Liu <guodong.liu@...iatek.corp-partner.google.com>
> > 
> > Add register address for each pin config.
> > Add the function for each pin.
> > 
> > Signed-off-by: Guodong Liu <guodong.liu@...iatek.com>
> > Cathy Xu <ot_cathy.xu@...iatek.com>
> > ---
> 
> Hi,
> 
> > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8196.h
> > b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8196.h
> > new file mode 100644
> > index 000000000000..9732ede74d9b
> > --- /dev/null
> > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8196.h
> > @@ -0,0 +1,2791 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * Copyright (C) 2024 Mediatek Inc.
> > + * Author: Guodong Liu <Guodong.Liu@...iatek.com>
> > + *
> > + */
> > +
> > +#ifndef __PINCTRL_MTK_MT8196_H
> > +#define __PINCTRL_MTK_MT8196_H
> > +
> 
> ...
> 
> > +     MTK_PIN(
> > +             292, "veint292",
> > +             MTK_EINT_FUNCTION(0, 292),
> > +             DRV_GRP4,
> > +             MTK_FUNCTION(0, NULL)
> > +     )
> > +};
> > +
> > +#endif /* __PINCTRL__MTK_MT8196_H */
> 
> Nitpick: there is an extra _ before MTK here.
  Thank you for your review. it will be fixed in next version.

>