linux-kernel - Re: [PATCH 2/8] drm/i915/gem: Use PG_dropbehind instead of PG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <136d0ec9-38a0-4de0-b5e1-d68686d5692d@redhat.com>
Date: Mon, 13 Jan 2025 11:06:26 +0100
From: David Hildenbrand <david@...hat.com>
To: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 "Matthew Wilcox (Oracle)" <willy@...radead.org>, Jens Axboe <axboe@...nel.dk>
Cc: "Jason A. Donenfeld" <Jason@...c4.com>,
 Andi Shyti <andi.shyti@...ux.intel.com>,
 Chengming Zhou <chengming.zhou@...ux.dev>,
 Christian Brauner <brauner@...nel.org>,
 Christophe Leroy <christophe.leroy@...roup.eu>,
 Dan Carpenter <dan.carpenter@...aro.org>, David Airlie <airlied@...il.com>,
 Hao Ge <gehao@...inos.cn>, Jani Nikula <jani.nikula@...ux.intel.com>,
 Johannes Weiner <hannes@...xchg.org>,
 Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
 Josef Bacik <josef@...icpanda.com>, Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Miklos Szeredi <miklos@...redi.hu>, Nhat Pham <nphamcs@...il.com>,
 Oscar Salvador <osalvador@...e.de>, Ran Xiaokai <ran.xiaokai@....com.cn>,
 Rodrigo Vivi <rodrigo.vivi@...el.com>, Simona Vetter <simona@...ll.ch>,
 Steven Rostedt <rostedt@...dmis.org>, Tvrtko Ursulin <tursulin@...ulin.net>,
 Vlastimil Babka <vbabka@...e.cz>, Yosry Ahmed <yosryahmed@...gle.com>,
 Yu Zhao <yuzhao@...gle.com>, intel-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
 linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH 2/8] drm/i915/gem: Use PG_dropbehind instead of PG_reclaim

On 13.01.25 10:34, Kirill A. Shutemov wrote:
> The recently introduced PG_dropbehind allows for freeing folios
> immediately after writeback. Unlike PG_reclaim, it does not need vmscan
> to be involved to get the folio freed.
> 
> Instead of using folio_set_reclaim(), use folio_set_dropbehind() in
> __shmem_writeback()
> 
> It is safe to leave PG_dropbehind on the folio if, for some reason
> (bug?), the folio is not in a writeback state after ->writepage().
> In these cases, the kernel had to clear PG_reclaim as it shared a page
> flag bit with PG_readahead.

I think this is correct

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb