linux-kernel - Re: [PATCH V2] mm: compaction: skip memory compaction when there are not enough migratable pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6b8ba92f-84df-4476-bc2c-985fc0cb254d@redhat.com>
Date: Mon, 13 Jan 2025 11:16:32 +0100
From: David Hildenbrand <david@...hat.com>
To: Baolin Wang <baolin.wang@...ux.alibaba.com>, yangge1116@....com,
 akpm@...ux-foundation.org
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, 21cnbao@...il.com,
 hannes@...xchg.org, liuzixing@...on.cn, Vlastimil Babka <vbabka@...e.cz>
Subject: Re: [PATCH V2] mm: compaction: skip memory compaction when there are
 not enough migratable pages

>> +	/*
>> +	 * Gup-pinned pages are non-migratable. After subtracting these pages,
>> +	 * we need to check if the remaining pages are sufficient for memory
>> +	 * compaction.
>> +	 */
>> +	if ((sum - nr_pinned) < (1 << order))
>> +		return false;
>> +
> 
> Looks reasonable to me, but let's see if other people have any comments.
> 

Noting that Barry had some concerns as reply to v3.

-- 
Cheers,

David / dhildenb