[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<CY4PR03MB3399E6CE276DEA511132FC009B1F2@CY4PR03MB3399.namprd03.prod.outlook.com>
Date: Mon, 13 Jan 2025 10:08:54 +0000
From: "Miclaus, Antoniu" <Antoniu.Miclaus@...log.com>
To: Nuno Sá <noname.nuno@...il.com>,
Krzysztof Kozlowski
<krzk@...nel.org>
CC: "jic23@...nel.org" <jic23@...nel.org>,
"robh@...nel.org"
<robh@...nel.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>,
"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>
Subject: RE: [PATCH v4 1/3] dt-bindings: iio: adf4371: add refin mode
--
Antoniu Miclăuş
> -----Original Message-----
> From: Nuno Sá <noname.nuno@...il.com>
> Sent: Monday, January 13, 2025 11:56 AM
> To: Krzysztof Kozlowski <krzk@...nel.org>; Miclaus, Antoniu
> <Antoniu.Miclaus@...log.com>
> Cc: jic23@...nel.org; robh@...nel.org; conor+dt@...nel.org; linux-
> iio@...r.kernel.org; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> linux-pwm@...r.kernel.org
> Subject: Re: [PATCH v4 1/3] dt-bindings: iio: adf4371: add refin mode
>
> [External]
>
> On Mon, 2025-01-13 at 09:37 +0100, Krzysztof Kozlowski wrote:
> > On Thu, Jan 09, 2025 at 03:37:05PM +0200, Antoniu Miclaus wrote:
> > > clock-names:
> > > description:
> > > - Must be "clkin"
> > > - maxItems: 1
> > > + Must be "clkin" if the input reference is single ended or "clkin-
> > > diff"
> > > + if the input reference is differential. By default single ended input
> > > is
> > > + applied.
> > > + enum: [clkin, clkin-diff]
> > > + default: clkin
> >
> > Which pins are these? I went through adf4371 datasheet and no reference
> > on clock inputs like clkin or clkin-diff.
> >
> >
>
> Hmm, I guess we should call this 'refp' and 'refp-n' then (the latter seems a
> bit more odd)? Or just 'ref' and 'ref-diff'?
Regarding both naming and approach, I followed Jonathan's suggestion in v3.
Initially it was a separate property for refin mode (see previous versions).
If he is fine with changing again the name/approach I'll do it, but I'd wait for
his comment.
> - Nuno Sá
Powered by blists - more mailing lists