linux-kernel - Re: [PATCH] dt-bindings: clock: add clock definitions for Ralink SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMhs-H9ysdJ9nUuStWJpRqTzm-09ZS5TMdhWgKMZx+JZdo6teQ@mail.gmail.com>
Date: Mon, 13 Jan 2025 12:32:12 +0100
From: Sergio Paracuellos <sergio.paracuellos@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: linux-clk@...r.kernel.org, sboyd@...nel.org, mturquette@...libre.com, 
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	yangshiji66@...look.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: clock: add clock definitions for Ralink SoCs

Hi Krzysztof,

On Mon, Jan 13, 2025 at 12:18 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 13/01/2025 09:28, Sergio Paracuellos wrote:
> > Add clock missing definitions for RT2880, RT305X, RT3352, RT3383, RT5350,
> > MT-7620 and MT-76X8 Ralink SoCs.
> >
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@...il.com>
>
> 1. Please use get_maintainers.

I did but from my tree which is tag: v6.12.5, linux-stable/linux-6.12.y. Sorry.

> 2. What is the point of this? We do not add constants when there are no
> users. Commit msg explains here nothing.

All of the old ralink SoCs' dts files which are in the tree are not
properly updated. I expect to have them updated somewhere in time
merging real base stuff from openwrt dts [0] files. Not having this
header with definitions makes very hard to update dts and then
checking the driver code becomes a need to see the indexes for the
clocks to properly setup a consumer node. Because of this, this file
is added here.

>
> > ---
> >  include/dt-bindings/clock/mtmips-clk.h | 130 +++++++++++++++++++++++++
>
> Filename matching compatible.

There are multiple compatibles regarding this, since the driver covers
a lot of SoCs. So I preferred to put them all in a single header file.
See [1]. Should I add a different file for any single compatible
instead?

>
> Best regards,
> Krzysztof

Thanks,
    Sergio Paracuellos

[0]: https://github.com/openwrt/openwrt/tree/main/target/linux/ramips/dts
[1]: https://elixir.bootlin.com/linux/v6.12.6/source/drivers/clk/ralink/clk-mtmips.c#L996