linux-kernel - Re: [PATCH v2] wifi: ath12k: fix key cache handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D70WWHYSPEY6.2TEXW2PF1C8SX@gmail.com>
Date: Mon, 13 Jan 2025 12:34:41 +0100
From: "Nicolas Escande" <nico.escande@...il.com>
To: "Aditya Kumar Singh" <quic_adisi@...cinc.com>, "Kalle Valo"
 <kvalo@...nel.org>, "Jeff Johnson" <jjohnson@...nel.org>, "Rameshkumar
 Sundaram" <quic_ramess@...cinc.com>
Cc: "Kalle Valo" <quic_kvalo@...cinc.com>, "Jeff Johnson"
 <quic_jjohnson@...cinc.com>, <linux-wireless@...r.kernel.org>,
 <ath12k@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] wifi: ath12k: fix key cache handling

On Sun Jan 12, 2025 at 6:53 AM CET, Aditya Kumar Singh wrote:
> Currently, an interface is created in the driver during channel assignment.
> If mac80211 attempts to set a key for an interface before this assignment,
> the driver caches the key. Once the interface is created, the driver
> installs the cached key to the hardware. This sequence is exemplified in
> mesh mode operation where the group key is set before channel assignment.
>
> However, in ath12k_mac_update_key_cache(), after caching the key, due to
> incorrect logic, it is deleted from the cache during the subsequent loop
> iteration. As a result, after the interface is created, the driver does not
> find any cached key, and the key is not installed to the hardware which is
> wrong. This leads to issue in mesh, where broadcast traffic is not
> encrypted over the air.
>
> Fix this issue by adjusting the logic of ath12k_mac_update_key_cache()
> properly.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
>
> Fixes: 25e18b9d6b4b ("wifi: ath12k: modify ath12k_mac_op_set_key() for MLO")
> Signed-off-by: Aditya Kumar Singh <quic_adisi@...cinc.com>
> ---
> Changes in v2:
> - Add 2025 Copyright

Tested-by: Nicolas Escande <nico.escande@...il.com>
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3-03253.1-QCAHKSWPL_SILICONZ-29
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1