linux-kernel - Re: [PATCH v2 2/3] arm64: dts: qcom: qcs9100: Update memory map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95647b2a-83ff-40d1-bcc4-1b7168286a53@kernel.org>
Date: Mon, 13 Jan 2025 13:20:22 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pratyush Brahma <quic_pbrahma@...cinc.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: qcs9100: Update memory map

On 13/01/2025 13:13, Pratyush Brahma wrote:
> Update the iot specific memory map for qcs9100* boards.
> 
> Signed-off-by: Pratyush Brahma <quic_pbrahma@...cinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts | 2 ++
>  arch/arm64/boot/dts/qcom/qcs9100-ride.dts    | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts
> index 759d1ec694b20e9cead674c1bd61c6a6627eeb27..06e57239bbe975b9c0b939d438095692243e39cf 100644
> --- a/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts
> @@ -5,6 +5,8 @@
>  /dts-v1/;
>  
>  #include "sa8775p-ride-r3.dts"
> +#include "sa8775p-iot.dtsi"

No. Either this is car or iot. Cannot be both.

In other threads I already complained you add some artificial split of
DTS/DTSI and not describing the hardware. This is another example of
that - you claim you have automotive board, which is derived from
automotive board, but it is not automotive and instead it is iot.

Decide about all this and come with DTS/DTSI structure reflecting actual
hardware, not how you want to organize your device nodes.

Best regards,
Krzysztof