linux-kernel - Re: [External Email] Re: [PATCH v6 2/2] serial: sc16is7xx: Add polling mode if no IRQ pin is available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z4UQ56-DDr8zim-e@smile.fi.intel.com>
Date: Mon, 13 Jan 2025 15:11:03 +0200
From: Andy Shevchenko <andy@...nel.org>
To: Andre Werner <andre.werner@...tec-electronic.com>
Cc: gregkh@...uxfoundation.org, jirislaby@...nel.org,
	hvilleneuve@...onoff.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	lech.perczak@...lingroup.com, krzk+dt@...nel.org,
	conor+dt@...nel.org, robh@...nel.org
Subject: Re: [External Email] Re: [PATCH v6 2/2] serial: sc16is7xx: Add
 polling mode if no IRQ pin is available

On Mon, Jan 13, 2025 at 02:02:25PM +0100, Andre Werner wrote:
> On Mon, 13 Jan 2025, Andy Shevchenko wrote:
> > On Mon, Jan 13, 2025 at 08:30:30AM +0100, Andre Werner wrote:

...

> > > +static void sc16is7xx_poll_proc(struct kthread_work *ws)
> > > +{
> > > +	struct sc16is7xx_port *s = container_of(ws, struct sc16is7xx_port, poll_work.work);
> > > +
> > > +	/* Reuse standard IRQ handler. Interrupt ID is unused in this context. */
> >
> > Period.
> 
> What do you expect here? Shall I add the period time from the define as
> the dedicated value? I do not understand what I should add here in
> detail.
> 
> >
> > > +	/* Setup delay based on SC16IS7XX_POLL_PERIOD_MS */
> >
> > No period.
> 
> Or do you mean that I add the define only once and not add all used
> places?

...

> > Please, go through the comments you added in the patch and use the style that
> > is mostly used in the driver for the similar (one-line comment) situations.

^^^ Read this. You have added three comments in two different styles.
It's not a big or anyhow critical issue in this case, it's matter of
the consistency with the existing style.

I expect that all three will in the same style, preferable the one
that is currently in use in the driver for other comments.

...

> > > +		/* Initialize kernel thread for polling */
> >
> > Again, no period.
> 
> Same here. Do you expect the value here or the name of the used define?


-- 
With Best Regards,
Andy Shevchenko