linux-kernel - Re: [PATCH 3/3] docs: submitting-patches: clarify that signers may use their discretion on tags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <523e2f74-ff67-42b1-8cc6-2956c856c833@sirena.org.uk>
Date: Mon, 13 Jan 2025 13:36:59 +0000
From: Mark Brown <broonie@...nel.org>
To: Neal Gompa <neal@...pa.dev>
Cc: Miguel Ojeda <ojeda@...nel.org>, Jonathan Corbet <corbet@....net>,
	workflows@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev,
	Sami Tolvanen <samitolvanen@...gle.com>,
	Masahiro Yamada <masahiroy@...nel.org>,
	Luis Chamberlain <mcgrof@...nel.org>,
	tech-board@...ups.linuxfoundation.org,
	Steven Rostedt <rostedt@...dmis.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Dan Williams <dan.j.williams@...el.com>,
	Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 3/3] docs: submitting-patches: clarify that signers may
 use their discretion on tags

On Sun, Jan 12, 2025 at 10:47:02AM -0500, Neal Gompa wrote:
> On Sun, Jan 12, 2025 at 10:30 AM Miguel Ojeda <ojeda@...nel.org> wrote:

> > +Finally, while providing tags is welcome and typically very appreciated, please
> > +note that signers (i.e. submitters and maintainers) may use their discretion in
> > +applying offered tags.
> > +

> A tag must not be dropped without the tag submitter's authorization.
> Otherwise it doesn't matter what you write here, the submitter *will*
> feel unwelcome.

> It is rude and discouraging to do so without their acceptance of doing so.

As well as the issues that Miguel and Greg mentioned there's cases where
we specifically want to drop tags, the most obvious one being that if a
patch or possibly even it's context changes substantially between
versions that will invalidate the testing or review that was done on
prior versions.  Perhaps we might want something like "please note that
while the default is to apply tags signers..." but I don't think we'd
want anything stronger.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)