linux-kernel - Re: [PATCH v2 5/5] HID: steelseries: remove unnecessary return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <009d72b2713aa3409bd607251339996a9371abc7.camel@hadess.net>
Date: Mon, 13 Jan 2025 14:42:36 +0100
From: Bastien Nocera <hadess@...ess.net>
To: Christian Mayer <git@...er-bgk.de>, linux-input@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Jiri Kosina <jikos@...nel.org>, Benjamin
 Tissoires <benjamin.tissoires@...hat.com>
Subject: Re: [PATCH v2 5/5] HID: steelseries: remove unnecessary return

On Sun, 2025-01-12 at 11:44 +0000, Christian Mayer wrote:
> Remove unnecessary return in a void function.
> 
> Signed-off-by: Christian Mayer <git@...er-bgk.de>

Reviewed-by: Bastien Nocera <hadess@...ess.net>
Tested-by: Bastien Nocera <hadess@...ess.net>

> ---
>  drivers/hid/hid-steelseries.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-steelseries.c b/drivers/hid/hid-
> steelseries.c
> index 1a935802880a..d4bd7848b8c6 100644
> --- a/drivers/hid/hid-steelseries.c
> +++ b/drivers/hid/hid-steelseries.c
> @@ -370,7 +370,6 @@ static void steelseries_srws1_remove(struct
> hid_device *hdev)
>  
>   hid_hw_stop(hdev);
>   kfree(drv_data);
> - return;
>  }
>  #endif
>