linux-kernel - Re: [PATCH v2] spmi: Fix controller->node != parent->node breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30474eee-cb88-4250-838a-3969073e0e8d@collabora.com>
Date: Mon, 13 Jan 2025 14:52:09 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Konrad Dybcio <konradybcio@...nel.org>,
 Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
 Stephen Boyd <sboyd@...nel.org>, Joe Hattori <joe@...is.s.u-tokyo.ac.jp>,
 Matthias Brugger <matthias.bgg@...il.com>
Cc: Marijn Suijten <marijn.suijten@...ainline.org>,
 linux-kernel@...r.kernel.org,
 Bjorn Andersson <bjorn.andersson@....qualcomm.com>,
 Abel Vesa <abel.vesa@...aro.org>, Johan Hovold <johan+linaro@...nel.org>,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH v2] spmi: Fix controller->node != parent->node breakage

Il 13/01/25 14:02, Konrad Dybcio ha scritto:
> From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> 
> On some platforms, like recent Qualcomm SoCs with multi-bus SPMI
> arbiters, controller->node must be assigned to the individual buses'
> subnodes, as the slave devices are children of these, like so:
> 
> arbiter@...0000
> 	spmi@...d000
> 		pmic@0
> 
> 	spmi@...2000
> 		pmic@0
> 
> The commit referenced in Fixes changed that assignment, such that
> spmi_controller_alloc() always assumes the PMICs come directly under
> the arbiter node (which is true when there's only a single bus per
> controller).
> 
> Make controller->node specifiable to both benefit from Joe's refcount
> improvements and un-break the aforementioned platforms.
> 
> Fixes: 821b07853e32 ("spmi: hisi-spmi-controller: manage the OF node reference in device initialization and cleanup")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

for spmi.c/.h, spmi-devres and for MediaTek:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

Cheers!