linux-kernel - Re: [PATCH] memory: omap-gpmc: Use of_property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqKHanejGiUhc78M7xCUPaqvvXojben0-m83HrzrRogpYw@mail.gmail.com>
Date: Mon, 13 Jan 2025 08:08:09 -0600
From: Rob Herring <robh@...nel.org>
To: Roger Quadros <rogerq@...nel.org>
Cc: Tony Lindgren <tony@...mide.com>, Krzysztof Kozlowski <krzk@...nel.org>, linux-omap@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memory: omap-gpmc: Use of_property_present() for
 non-boolean properties

On Fri, Jan 10, 2025 at 3:08 AM Roger Quadros <rogerq@...nel.org> wrote:
>
> Hi Rob,
>
> On 09/01/2025 20:21, Rob Herring (Arm) wrote:
> > The use of of_property_read_bool() for non-boolean properties is
> > deprecated in favor of of_property_present() when testing for property
> > presence.
> >
> > While we're here, simplify the 2 checks into a single check as they
> > only differ in printing "NAND" vs "OneNAND" in the warning.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> > ---
> > Possibly this check could just be removed altogether?
>
> Yes, I agree it is better to just drop these checks.
> Let me know if you want me to prepare the path. Thanks.

Please do. You would know better than me on the details of why it
would be fine to remove.

Rob