linux-kernel - Re: [RFC v2 2/2] ASoC: dapm: add support for preparing streams

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4Uf1XmwYH3TIcAO@opensource.cirrus.com>
Date: Mon, 13 Jan 2025 14:14:45 +0000
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
CC: <linux-sound@...r.kernel.org>, <linux-amlogic@...ts.infradead.org>,
        <s.nawrocki@...sung.com>, <lgirdwood@...il.com>, <broonie@...nel.org>,
        <linux-kernel@...r.kernel.org>, <jbrunet@...libre.com>
Subject: Re: [RFC v2 2/2] ASoC: dapm: add support for preparing streams

On Fri, Jan 10, 2025 at 10:07:30PM +0100, Martin Blumenstingl wrote:
> Codec driver can implement .hw_params and/or .prepare from struct
> snd_soc_dai_ops. For codec-to-codec links only the former (.hw_params)
> callback has been called.
> 
> On platforms like Amlogic Meson8/8b/8m2 the SoC's sound card
> (sound/soc/meson/gx-card.c) uses a codec-to-codec link for the HDMI
> codec output because further digital routing is required after the
> backend. The new DRM HDMI (audio) codec framework (which internally
> uses sound/soc/codecs/hdmi-codec.c) relies on the .prepare callback
> of the hdmi-codec to be called. Implement calls to
> snd_soc_dai_prepare() so the .prepare callback is called. In this
> case the mandatory part is the call to prepare the sink (which is
> the hdmi-codec on those platforms). Also call snd_soc_dai_prepare()
> for the source to stay consistent with the rest of the code (even
> though it's not strictly necessary to make the DRM HDMI codec
> framework work on Amlogic Meson8/8b/8m2).
> 
> For platforms or sound cards without a codec-to-codec link with
> additional parameters (which applies to most hardware) this changes
> nothing as the .prepare callback is already called via
> snd_pcm_do_prepare() (as well as dpcm_fe_dai_prepare() and
> dpcm_be_dai_prepare()) on those.
> 
> Suggested-by: Jerome Brunet <jbrunet@...libre.com>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> ---

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles