linux-kernel - Re: [PATCH 3/3] docs: submitting-patches: clarify that signers may use their discretion on tags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250113142227.GE1514771@mit.edu>
Date: Mon, 13 Jan 2025 09:22:27 -0500
From: "Theodore Ts'o" <tytso@....edu>
To: Neal Gompa <neal@...pa.dev>
Cc: Miguel Ojeda <ojeda@...nel.org>, Jonathan Corbet <corbet@....net>,
        workflows@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, patches@...ts.linux.dev,
        Sami Tolvanen <samitolvanen@...gle.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        tech-board@...ups.linuxfoundation.org,
        Steven Rostedt <rostedt@...dmis.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 3/3] docs: submitting-patches: clarify that signers may
 use their discretion on tags

On Sun, Jan 12, 2025 at 10:47:02AM -0500, Neal Gompa wrote:
> 
> A tag must not be dropped without the tag submitter's authorization.
> Otherwise it doesn't matter what you write here, the submitter *will*
> feel unwelcome.
> 
> It is rude and discouraging to do so without their acceptance of doing so.

In some cases, if the reviewer hasn't taken the less than subtle hints
that their reviews are unwelcome and are discouraging patch
submitters, as far as I'm concerned, if they feel unwelcome, that is a
*feature* and not a *bug*.

I'm not saying that is the case for you, but there are reviewers that
add negative value in the ecosystem.  The assumption that all tag
submitters are people that need to feel welcome might mostly true, but
it is not always the case.  This is why it MUST ultimately be up to
the maintainer.  I do not want the rules that force me to reward
people that should be discouraged, not encouraged.

						- Ted