linux-kernel - Re: [PATCH next] efivarfs: Fix a NULL vs IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68a5cabb-c5b3-4090-b9be-bdb34ea5a35e@stanley.mountain>
Date: Mon, 13 Jan 2025 17:25:56 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Ard Biesheuvel <ardb@...nel.org>
Cc: James Bottomley <James.Bottomley@...senpartnership.com>,
	Jeremy Kerr <jk@...abs.org>, linux-efi@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] efivarfs: Fix a NULL vs IS_ERR() bug

On Mon, Jan 13, 2025 at 03:18:05PM +0100, Ard Biesheuvel wrote:
> On Mon, 13 Jan 2025 at 07:16, Dan Carpenter <dan.carpenter@...aro.org> wrote:
> >
> > The kernel_file_open() function doesn't return NULL, it retursn error
> > pointers.  Fix the error checking to match.
> >
> > Fixes: eb11e99adef8 ("efivarfs: add variable resync after hibernation")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> > ---
> >  fs/efivarfs/super.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> 
> Thanks - I'll fold this in rather than apply it on top though.

Sure.  No worries.

regards,
dan carpenter