linux-kernel - Re: [PATCH] wifi: wilc1000: unregister wiphy only after netdev registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d26a4283-a4fe-4ec6-9601-c239281335ac@bootlin.com>
Date: Tue, 14 Jan 2025 16:44:50 +0100
From: Alexis Lothoré <alexis.lothore@...tlin.com>
To: Kalle Valo <kvalo@...nel.org>
Cc: Ajay Singh <ajay.kathat@...rochip.com>,
 Claudiu Beznea <claudiu.beznea@...on.dev>, Marek Vasut <marex@...x.de>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: wilc1000: unregister wiphy only after netdev
 registration

On 1/14/25 14:20, Kalle Valo wrote:
> Alexis Lothoré <alexis.lothore@...tlin.com> writes:

[...]

>>>> @Kalle: 89a7616e1715 (the faulty commit) is only in wireless-next for
>>>> now IIUC, so I did not provide any Fixes: tag to prevent any faulty SHA1
>>>> if those commits end up being picked in stable tree (however, the faulty
>>>> commit _has_ a Fixes tag). Please let me know if we should proceed
>>>> differently.
>>>
>>> Hmm, I don't really follow you here. I feel that always adding the Fixes
>>> tag is the safest option, that way it's clear for everyone what commit
>>> we are fixing.
>>
>> I was thinking about the fact that the faulty commit SHA1 may change because of
>> a merge, and then break the Fixes: tag, but maybe I am overthinking.
> 
> Ah, now I understand. Actually commit id doesn't change during a merge
> so we are safe in that regard. The commit id only changes if there's a
> rebase in the tree and we don't rebase wireless trees (unless something
> really drastic has happened).

ACK

>> So if it's ok for you, I would like to add the Fixes tag
>>> but I can't find commit 89a7616e1715 anywhere.
>>
>> Gaah, indeed that's not the correct SHA1. The faulty commit in wireless-next is
>> in fact commit 1be94490b6b8 ("wifi: wilc1000: unregister wiphy only if it has
>> been registered")
> 
> Thanks, so I'm planning to add this during commit:
> 
> Fixes: 1be94490b6b8 ("wifi: wilc1000: unregister wiphy only if it has been registered")
> 
> Is that ok?

Ok for me, thanks !

Alexis


-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com