linux-kernel - Re: [PATCH v2 linux-next 1/2] lib/string_choices: Rearrange functions in sorted order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <58751174-1dc4-4467-aed3-e387261dba78@gmail.com>
Date: Tue, 14 Jan 2025 21:33:16 +0530
From: R Sundar <prosunofficial@...il.com>
To: Larysa Zaremba <larysa.zaremba@...el.com>
Cc: Kees Cook <kees@...nel.org>, Andy Shevchenko <andy@...nel.org>,
 linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org,
 Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH v2 linux-next 1/2] lib/string_choices: Rearrange functions
 in sorted order

On 14/01/25 18:03, Larysa Zaremba wrote:
> On Tue, Nov 19, 2024 at 07:47:18AM +0530, R Sundar wrote:
>> Rearrange misplaced functions in sorted order.
>>
>> Suggested-by: Andy Shevchenko <andy.shevchenko@...il.com>
>> Signed-off-by: R Sundar <prosunofficial@...il.com>
> 
> Reviewed-by: Larysa Zaremba <larysa.zaremba@...el.com>
> 
> This is a much-needed patch.
> 
> R Sundar,
> Can I pick it into my series in case it will not be accepted in the nearest
> future? (I do not promise this, but there is a chance)
> 
Hi,

Yes, Please.

Thanks.

Best Regards,
Sundar

>> ---
>>   include/linux/string_choices.h | 24 ++++++++++++------------
>>   1 file changed, 12 insertions(+), 12 deletions(-)
>>
>> diff --git a/include/linux/string_choices.h b/include/linux/string_choices.h
>> index 120ca0f28e95..f3ba4f52ff26 100644
>> --- a/include/linux/string_choices.h
>> +++ b/include/linux/string_choices.h
>> @@ -41,23 +41,23 @@ static inline const char *str_high_low(bool v)
>>   }
>>   #define str_low_high(v)		str_high_low(!(v))
>>   
>> -static inline const char *str_read_write(bool v)
>> -{
>> -	return v ? "read" : "write";
>> -}
>> -#define str_write_read(v)		str_read_write(!(v))
>> -
>>   static inline const char *str_on_off(bool v)
>>   {
>>   	return v ? "on" : "off";
>>   }
>>   #define str_off_on(v)		str_on_off(!(v))
>>   
>> -static inline const char *str_yes_no(bool v)
>> +static inline const char *str_read_write(bool v)
>>   {
>> -	return v ? "yes" : "no";
>> +	return v ? "read" : "write";
>>   }
>> -#define str_no_yes(v)		str_yes_no(!(v))
>> +#define str_write_read(v)		str_read_write(!(v))
>> +
>> +static inline const char *str_true_false(bool v)
>> +{
>> +	return v ? "true" : "false";
>> +}
>> +#define str_false_true(v)		str_true_false(!(v))
>>   
>>   static inline const char *str_up_down(bool v)
>>   {
>> @@ -65,11 +65,11 @@ static inline const char *str_up_down(bool v)
>>   }
>>   #define str_down_up(v)		str_up_down(!(v))
>>   
>> -static inline const char *str_true_false(bool v)
>> +static inline const char *str_yes_no(bool v)
>>   {
>> -	return v ? "true" : "false";
>> +	return v ? "yes" : "no";
>>   }
>> -#define str_false_true(v)		str_true_false(!(v))
>> +#define str_no_yes(v)		str_yes_no(!(v))
>>   
>>   /**
>>    * str_plural - Return the simple pluralization based on English counts
>> -- 
>> 2.34.1
>>