linux-kernel - Re: [PATCH 1/2] checkpatch: Add support for Checkpatch-ignore patch footer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250114-tapir-of-splendid-leadership-ad115e@lemur>
Date: Tue, 14 Jan 2025 11:04:00 -0500
From: Konstantin Ryabitsev <konstantin@...uxfoundation.org>
To: Brendan Jackman <jackmanb@...gle.com>
Cc: Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>, 
	Dwaipayan Ray <dwaipayanray1@...il.com>, Lukas Bulwahn <lukas.bulwahn@...il.com>, 
	Jonathan Corbet <corbet@....net>, linux-kernel@...r.kernel.org, workflows@...r.kernel.org, 
	linux-doc@...r.kernel.org
Subject: Re: [PATCH 1/2] checkpatch: Add support for Checkpatch-ignore patch
 footer

On Tue, Jan 14, 2025 at 03:25:41PM +0100, Brendan Jackman wrote:
> <konstantin@...uxfoundation.org> wrote:
> > Do we really want this to become part of the permanent commit message? I'm
> > pretty sure this won't go over well with many.
> 
> Why not?

Tweaks aimed at checkpatch are only useful during the code review stage, so
once that code is accepted upstream, they become wholly irrelevant. A
checkpatch trailer in the permanent commit record serves no purpose, not even
a historical one.

At best, utility trailers like that need to go into the basement of the patch,
not into the commit message.

-K