linux-kernel - Re: [PATCH] selftests/rseq: Fix rseq for cases without glibc support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <af9577f7-71fb-4760-9bd6-c3fc43aa0f30@linuxfoundation.org>
Date: Tue, 14 Jan 2025 09:12:45 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Raghavendra Rao Ananta <rananta@...gle.com>
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
 linux-kselftest@...r.kernel.org, stable@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests/rseq: Fix rseq for cases without glibc support

On 1/14/25 07:27, Mathieu Desnoyers wrote:
> On 2025-01-14 09:07, Mathieu Desnoyers wrote:
>> On 2025-01-13 18:06, Shuah Khan wrote:
>>> On 12/10/24 15:44, Raghavendra Rao Ananta wrote:
>>>> Currently the rseq constructor, rseq_init(), assumes that glibc always
>>>> has the support for rseq symbols (__rseq_size for instance). However,
>>>> glibc supports rseq from version 2.35 onwards. As a result, for the
>>>> systems that run glibc less than 2.35, the global rseq_size remains
>>>> initialized to -1U. When a thread then tries to register for rseq,
>>>> get_rseq_min_alloc_size() would end up returning -1U, which is
>>>> incorrect. Hence, initialize rseq_size for the cases where glibc doesn't
>>>> have the support for rseq symbols.
>>>>
>>>> Cc: stable@...r.kernel.org
>>>> Fixes: 73a4f5a704a2 ("selftests/rseq: Fix mm_cid test failure")
>>>> Signed-off-by: Raghavendra Rao Ananta <rananta@...gle.com>
>>>> ---
>>>
>>> Applied to linux_kselftest next for Linux 6.14-rc1 after fixing the
>>> commit if for Fixes tag
>>
>> Hi Shuah,
>>
>> I did not review nor ack this patch. I need to review it carefully
>> to make sure it does not break anything else moving forward.
>>
>> Please wait before merging.
> 
> I am preparing an alternative fix which keeps the selftests
> code in sync with librseq.
> 

Sorry for the mixup. I will go drop this now.

thanks,
-- Shuah