linux-kernel - [PATCH] memory: omap-gpmc: drop no compatible check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250114-omap-gpmc-drop-no-compatible-check-v1-1-262c8d549732@kernel.org>
Date: Tue, 14 Jan 2025 18:36:28 +0200
From: Roger Quadros <rogerq@...nel.org>
To: Tony Lindgren <tony@...mide.com>, Krzysztof Kozlowski <krzk@...nel.org>
Cc: linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org, 
 "Rob Herring (Arm)" <robh@...nel.org>, Roger Quadros <rogerq@...nel.org>
Subject: [PATCH] memory: omap-gpmc: drop no compatible check

We are no longer depending on legacy device trees so
drop the no compatible check for NAND and OneNAND
nodes.

Suggested-by: Rob Herring (Arm) <robh@...nel.org>
Signed-off-by: Roger Quadros <rogerq@...nel.org>
---
 drivers/memory/omap-gpmc.c | 20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index 50eb9f49512b..368b0848b64d 100644
--- a/drivers/memory/omap-gpmc.c
+++ b/drivers/memory/omap-gpmc.c
@@ -2245,26 +2245,6 @@ static int gpmc_probe_generic_child(struct platform_device *pdev,
 		goto err;
 	}
 
-	if (of_node_name_eq(child, "nand")) {
-		/* Warn about older DT blobs with no compatible property */
-		if (!of_property_read_bool(child, "compatible")) {
-			dev_warn(&pdev->dev,
-				 "Incompatible NAND node: missing compatible");
-			ret = -EINVAL;
-			goto err;
-		}
-	}
-
-	if (of_node_name_eq(child, "onenand")) {
-		/* Warn about older DT blobs with no compatible property */
-		if (!of_property_read_bool(child, "compatible")) {
-			dev_warn(&pdev->dev,
-				 "Incompatible OneNAND node: missing compatible");
-			ret = -EINVAL;
-			goto err;
-		}
-	}
-
 	if (of_match_node(omap_nand_ids, child)) {
 		/* NAND specific setup */
 		val = 8;

---
base-commit: 5bc55a333a2f7316b58edc7573e8e893f7acb532
change-id: 20250114-omap-gpmc-drop-no-compatible-check-c9183d316591

Best regards,
-- 
Roger Quadros <rogerq@...nel.org>