linux-kernel - Re: [PATCH RFC v2] of: property: Fix potential firmware node reference's argument count got out of range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z4aYZtR3WcbpCRui@smile.fi.intel.com>
Date: Tue, 14 Jan 2025 19:01:26 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Zijun Hu <zijun_hu@...oud.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	"Rob Herring (Arm)" <robh@...nel.org>, Len Brown <lenb@...nel.org>,
	Daniel Scally <djrscally@...il.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH RFC v2] of: property: Fix potential firmware node
 reference's argument count got out of range

On Tue, Jan 14, 2025 at 11:51:13PM +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@...cinc.com>
> 
> Currently, the following two macros have different values:
> 
> // The maximal argument count for firmware node reference
>  #define NR_FWNODE_REFERENCE_ARGS	8
> // The maximal argument count for OF node reference
>  #define MAX_PHANDLE_ARGS 16
> 
> But of_fwnode_get_reference_args() directly assigns OF node
> reference argument count @of_args.args_count to frimware

firmware

> @args->nargs, and may cause firmware node reference argument
> count @of_args.args_count got out of range, namely, in [9, 16].
> 
> Fix by increasing NR_FWNODE_REFERENCE_ARGS to 16 to meet OF requirement.

-- 
With Best Regards,
Andy Shevchenko