linux-kernel - Re: [PATCH -v2 next 2/4] memcg: call the free function when allocation of pn fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4auyCo_V4e-2GU3@google.com>
Date: Tue, 14 Jan 2025 18:36:56 +0000
From: Roman Gushchin <roman.gushchin@...ux.dev>
To: Chen Ridong <chenridong@...weicloud.com>
Cc: akpm@...ux-foundation.org, mhocko@...nel.org, hannes@...xchg.org,
	yosryahmed@...gle.com, shakeel.butt@...ux.dev,
	muchun.song@...ux.dev, davidf@...eo.com, vbabka@...e.cz,
	mkoutny@...e.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	cgroups@...r.kernel.org, chenridong@...wei.com,
	wangweiyang2@...wei.com
Subject: Re: [PATCH -v2 next 2/4] memcg: call the free function when
 allocation of pn fails

On Tue, Jan 14, 2025 at 12:25:17PM +0000, Chen Ridong wrote:
> From: Chen Ridong <chenridong@...wei.com>
> 
> The 'free_mem_cgroup_per_node_info' function is used to free
> the 'mem_cgroup_per_node' struct. Using 'pn' as the input for the
> free_mem_cgroup_per_node_info function will be much clearer.
> Call 'free_mem_cgroup_per_node_info' when 'alloc_mem_cgroup_per_node_info'
> fails, to free 'pn' as a whole, which makes the code more cohesive.
> 
> Signed-off-by: Chen Ridong <chenridong@...wei.com>
> Reviewed-by: Michal Koutný <mkoutny@...e.com>
> Acked-by: Shakeel Butt <shakeel.butt@...ux.dev>

Reviewed-by: Roman Gushchin <roman.gushchin@...ux.dev>