linux-kernel - Re: [PATCH] MIPS: pci-legacy: Override pci_address_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5ef27e01-2c5a-400a-be32-d3bcdeea6d26@app.fastmail.com>
Date: Tue, 14 Jan 2025 20:03:12 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Jiaxun Yang" <jiaxun.yang@...goat.com>,
 "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
 "Baoquan He" <bhe@...hat.com>
Cc: linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org, Mateusz Jończyk <mat.jonczyk@...pl>
Subject: Re: [PATCH] MIPS: pci-legacy: Override pci_address_to_pio

On Tue, Jan 14, 2025, at 19:11, Jiaxun Yang wrote:
> 
> +unsigned long pci_address_to_pio(phys_addr_t address)
> +{
> +	if (address > IO_SPACE_LIMIT)
> +		return (unsigned long)-1;
> +
> +	return (unsigned long) address;
> +}
> +
>  /*

Isn't the argument to this function a CPU physical address? I
don't think there is a point comparing it to IO_SPACE_LIMIT
on architectures where I/O space is memory mapped.

I see that you copied the above from the the non-PCI_IOBASE case
of drivers/pci/pci.c, but that only really makes sense for
architectures that have special port I/O instructions (x86,
ia64) or that use logic_pio.

      Arnd