linux-kernel - Re: [PATCH v2] wifi: ath12k: fix key cache handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173688805235.2759377.5453459200658358926.b4-ty@oss.qualcomm.com>
Date: Tue, 14 Jan 2025 12:54:12 -0800
From: Jeff Johnson <jeff.johnson@....qualcomm.com>
To: Kalle Valo <kvalo@...nel.org>, Jeff Johnson <jjohnson@...nel.org>,
        Rameshkumar Sundaram <quic_ramess@...cinc.com>,
        Aditya Kumar Singh <quic_adisi@...cinc.com>
Cc: Kalle Valo <quic_kvalo@...cinc.com>,
        Jeff Johnson <quic_jjohnson@...cinc.com>,
        linux-wireless@...r.kernel.org, ath12k@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] wifi: ath12k: fix key cache handling


On Sun, 12 Jan 2025 11:23:00 +0530, Aditya Kumar Singh wrote:
> Currently, an interface is created in the driver during channel assignment.
> If mac80211 attempts to set a key for an interface before this assignment,
> the driver caches the key. Once the interface is created, the driver
> installs the cached key to the hardware. This sequence is exemplified in
> mesh mode operation where the group key is set before channel assignment.
> 
> However, in ath12k_mac_update_key_cache(), after caching the key, due to
> incorrect logic, it is deleted from the cache during the subsequent loop
> iteration. As a result, after the interface is created, the driver does not
> find any cached key, and the key is not installed to the hardware which is
> wrong. This leads to issue in mesh, where broadcast traffic is not
> encrypted over the air.
> 
> [...]

Applied, thanks!

[1/1] wifi: ath12k: fix key cache handling
      commit: 336097d74c284a7c928b723ce8690f28912da03d

Best regards,
-- 
Jeff Johnson <jeff.johnson@....qualcomm.com>