linux-kernel - Re: [PATCH next] squashfs: Fix a NULL vs IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d4adbf20-2d14-4a0f-9f2d-5132f87ec493@squashfs.org.uk>
Date: Tue, 14 Jan 2025 21:06:05 +0000
From: Phillip Lougher <phillip@...ashfs.org.uk>
To: Dan Carpenter <dan.carpenter@...aro.org>,
 Matthew Wilcox <willy@...radead.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] squashfs: Fix a NULL vs IS_ERR() bug



On 1/8/25 09:16, Dan Carpenter wrote:
> The __filemap_get_folio() functoin never returns NULL, it returns
> error pointers.  This incorrect check would lead to an Oops on the
> following line when we pass "push_folio" to folio_test_uptodate().
> 
> Fixes: 43c73ba98b2c ("squashfs; convert squashfs_copy_cache() to take a folio")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Phillip Lougher <phillip@...ashfs.org.uk>