linux-kernel - Re: [PATCH] crypto: bcm - Drop unused setting of local 'ptr' variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z4Xdypd1OQSrOYrl@gondor.apana.org.au>
Date: Tue, 14 Jan 2025 11:45:14 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: "David S. Miller" <davem@...emloft.net>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] crypto: bcm - Drop unused setting of local 'ptr' variable

On Sat, Jan 04, 2025 at 09:55:02PM +0100, Krzysztof Kozlowski wrote:
> spum_cipher_req_init() assigns 'spu_hdr' to local 'ptr' variable and
> later increments 'ptr' over specific fields like it was meant to point
> to pieces of message for some purpose.  However the code does not read
> 'ptr' at all thus this entire iteration over 'spu_hdr' seams pointless.
> 
> Reported by clang W=1 build:
> 
>   drivers/crypto/bcm/spu.c:839:6: error: variable 'ptr' set but not used [-Werror,-Wunused-but-set-variable]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/crypto/bcm/spu.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt