linux-kernel - Re: [PATCH v3 1/3] drm/amd/display: Add ASSERT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhV-H56-xQm5XnS7M4weHj29Z_bB8ZBiF_H4fd+eGe6g+naow@mail.gmail.com>
Date: Tue, 14 Jan 2025 16:29:20 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc: Alex Deucher <alexander.deucher@....com>, 
	Christian König <christian.koenig@....com>, 
	Xinhui Pan <Xinhui.Pan@....com>, Harry Wentland <harry.wentland@....com>, Leo Li <sunpeng.li@....com>, 
	Rodrigo Siqueira <Rodrigo.Siqueira@....com>, Nathan Chancellor <nathan@...nel.org>, 
	Josh Poimboeuf <jpoimboe@...nel.org>, Peter Zijlstra <peterz@...radead.org>, loongarch@...ts.linux.dev, 
	amd-gfx@...ts.freedesktop.org, llvm@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] drm/amd/display: Add ASSERT_BUG() macro definition

Hi, Tiezhu,

On Tue, Jan 14, 2025 at 2:16 PM Tiezhu Yang <yangtiezhu@...ngson.cn> wrote:
>
> In order to keep the current ability for the aim of debugging and avoid
> printing the warning message twice, add ASSERT_BUG() macro definition to
> harden the callers of division functions.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> ---
>  drivers/gpu/drm/amd/display/dc/os_types.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/os_types.h b/drivers/gpu/drm/amd/display/dc/os_types.h
> index f2ba76c1e0c0..932bbe05ee0a 100644
> --- a/drivers/gpu/drm/amd/display/dc/os_types.h
> +++ b/drivers/gpu/drm/amd/display/dc/os_types.h
> @@ -79,6 +79,11 @@
>                         dc_breakpoint();        \
>         } while (0)
>
> +#define ASSERT_BUG(expr) do {                  \
> +               dc_breakpoint();                \
> +               BUG_ON(!(expr));                \
> +       } while (0)
I don't think this is correct, if KGDB is enabled, then whether expr
is true or false, ASSERT_BUG() will break to KGDB.

Huacai

> +
>  #define BREAK_TO_DEBUGGER() \
>         do { \
>                 DRM_DEBUG_DRIVER("%s():%d\n", __func__, __LINE__); \
> --
> 2.42.0
>
>