linux-kernel - [PATCH 1/2] get_maintainer: decouple subsystem status from maintainer role

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250114-b4-get_maintainer-v1-1-ecf40f0d032d@suse.cz>
Date: Tue, 14 Jan 2025 09:57:54 +0100
From: Vlastimil Babka <vbabka@...e.cz>
To: Joe Perches <joe@...ches.com>
Cc: workflows@...r.kernel.org, Theodore Ts'o <tytso@....edu>, 
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>, 
 Thorsten Leemhuis <linux@...mhuis.info>, Kees Cook <kees@...nel.org>, 
 linux-kernel@...r.kernel.org, Vlastimil Babka <vbabka@...e.cz>
Subject: [PATCH 1/2] get_maintainer: decouple subsystem status from
 maintainer role

The script currently uses the subystem's status (S: field in
MAINTAINERS) to change how maintainers are reported. One prominent
example is when the status is Supported, the maintainers are reported as
"(supporter:SUBSYSTEM)".

This is misleading, as the Supported status defined as "Someone is
actually paid to look after this." may not in fact apply to everyone
listed as a maintainer, but only to a subset.

It has also been confusing people about what "supporter" means and has
required updates to the documentation [1].

Thus stop applying the subsystem status to change "maintainer:" to
anything else, as maintainers are maintainers. Instead, if the subsystem
status is not the most common one (Maintained), indicate it as part of
the subsystem name. So for example, instead of "(supporter:SUBSYSTEM)"
report "(maintainer:SUBSYSTEM [supported])".

The only exception not changed here is the status "Buried alive in
reporters" used only in "THE REST" section and reported as "chief
penguin" because the script uses the same terminology also for the
corresponding (non-default) command line option.

[1] https://lore.kernel.org/all/20221006162413.858527-1-bryan.odonoghue@linaro.org/

Reviewed-by: Kees Cook <kees@...nel.org>
Signed-off-by: Vlastimil Babka <vbabka@...e.cz>
---
 scripts/get_maintainer.pl | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 5ac02e19873722d0f5bf3ac8de8374338c7bddc3..82a0032f4d4c7dad876afeb601b5f1957d1a838f 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -1286,6 +1286,7 @@ sub get_maintainer_role {

     my $role = "unknown";
     my $subsystem = get_subsystem_name($index);
+    my $substatus = "";

     for ($i = $start + 1; $i < $end; $i++) {
 	my $tv = $typevalue[$i];
@@ -1299,21 +1300,15 @@ sub get_maintainer_role {
     }

     $role = lc($role);
-    if      ($role eq "supported") {
-	$role = "supporter";
-    } elsif ($role eq "maintained") {
+    if ($role eq "maintained") {
 	$role = "maintainer";
-    } elsif ($role eq "odd fixes") {
-	$role = "odd fixer";
-    } elsif ($role eq "orphan") {
-	$role = "orphan minder";
-    } elsif ($role eq "obsolete") {
-	$role = "obsolete minder";
     } elsif ($role eq "buried alive in reporters") {
 	$role = "chief penguin";
+    } else {
+	$substatus = " [" . $role . "]";
+	$role = "maintainer";
     }
-
-    return $role . ":" . $subsystem;
+    return $role . ":" . $subsystem . $substatus;
 }

 sub get_list_role {

-- 
2.47.1