linux-kernel - Re: [PATCH 2/2] drm/panel: simple: Add DataImage FG080016DNCWAG03 driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3688ad34-86a2-4762-86ee-cbac8c3b9aa7@linaro.org>
Date: Tue, 14 Jan 2025 10:44:14 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Jonas Rebmann <jre@...gutronix.de>,
 Jessica Zhang <quic_jesszhan@...cinc.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Thierry Reding
 <thierry.reding@...il.com>, Sam Ravnborg <sam@...nborg.org>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH 2/2] drm/panel: simple: Add DataImage FG080016DNCWAG03
 driver support

On 09/01/2025 12:34, Jonas Rebmann wrote:
> Add DataImage FG080016DNCWAG03 8" 640x480 TFT LCD panel support.
> 
> Signed-off-by: Jonas Rebmann <jre@...gutronix.de>
> ---
>   drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
>   1 file changed, 28 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 222c170dde8be261e98ff41168ef8a3a42c167c8..14d4cf235036cfd662bf16cb794ea2454d6fd2b2 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1734,6 +1734,31 @@ static const struct panel_desc dataimage_fg040346dsswbg04 = {
>   	.connector_type = DRM_MODE_CONNECTOR_DPI,
>   };
>   
> +static const struct display_timing dataimage_fg080016dncwag03_timing = {
> +	.pixelclock = { 24000000, 25000000, 32500000 },
> +	.hactive = { 640, 640, 640 },
> +	.hfront_porch = { 64, 70, 115 },
> +	.hback_porch =  { 64, 70, 115 },
> +	.hsync_len = { 20, 20, 20 },
> +	.vactive = { 480, 480, 480 },
> +	.vfront_porch = { 8, 12, 30 },
> +	.vback_porch =  { 8, 13, 31 },
> +	.vsync_len = { 20, 20, 20 },
> +};
> +
> +static const struct panel_desc dataimage_fg080016dncwag03 = {
> +	.timings = &dataimage_fg080016dncwag03_timing,
> +	.num_timings = 1,
> +	.bpc = 6,
> +	.size = {
> +		.width = 217,
> +		.height = 136,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
> +	.connector_type = DRM_MODE_CONNECTOR_DPI,
> +};
> +
>   static const struct display_timing dataimage_fg1001l0dsswmg01_timing = {
>   	.pixelclock = { 68900000, 71110000, 73400000 },
>   	.hactive = { 1280, 1280, 1280 },
> @@ -4731,6 +4756,9 @@ static const struct of_device_id platform_of_match[] = {
>   	}, {
>   		.compatible = "dataimage,fg040346dsswbg04",
>   		.data = &dataimage_fg040346dsswbg04,
> +	}, {
> +		.compatible = "dataimage,fg080016dncwag03",
> +		.data = &dataimage_fg080016dncwag03,
>   	}, {
>   		.compatible = "dataimage,fg1001l0dsswmg01",
>   		.data = &dataimage_fg1001l0dsswmg01,
> 

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>