linux-kernel - Re: [PATCH v11 2/8] mm: rust: add vm_area_struct methods that require read access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH5fLggntnvMLoZHTm6zx3nSP4nq7iruK2c6iXBX-CXtVPYbcA@mail.gmail.com>
Date: Tue, 14 Jan 2025 10:50:01 +0100
From: Alice Ryhl <aliceryhl@...gle.com>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: Andreas Hindborg <a.hindborg@...nel.org>, Miguel Ojeda <ojeda@...nel.org>, 
	Matthew Wilcox <willy@...radead.org>, Vlastimil Babka <vbabka@...e.cz>, John Hubbard <jhubbard@...dia.com>, 
	"Liam R. Howlett" <Liam.Howlett@...cle.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Arnd Bergmann <arnd@...db.de>, 
	Christian Brauner <brauner@...nel.org>, Jann Horn <jannh@...gle.com>, 
	Suren Baghdasaryan <surenb@...gle.com>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Trevor Gross <tmgross@...ch.edu>, linux-kernel@...r.kernel.org, 
	linux-mm@...ck.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v11 2/8] mm: rust: add vm_area_struct methods that require
 read access

On Mon, Jan 13, 2025 at 3:45 PM Lorenzo Stoakes
<lorenzo.stoakes@...cle.com> wrote:
> > >> > For a series at v11 where there is broad agreement with maintainers within
> > >> > the subsystem which it wraps, perhaps the priority should be to try to have
> > >> > the series merged unless there is significant technical objection from the
> > >> > rust side?
> > >> >
> > >> >>
> > >> >> How about this:
> > >> >>
> > >> >> This clears the virtual memory map for the range given by `start` and
> > >> >> `size`, dropping refcounts to memory held by the mappings in this range. That
> > >> >> is, anonymous memory is completely freed, file-backed memory has its
> > >> >> reference count on page cache folio's dropped, any dirty data will still
> > >> >> be written back to disk as usual.
> > >> >
> > >> > Sorry I object to this, 'clears the virtual memory map' is really
> > >> > vague. What is already there is better.
> > >>
> > >> Would you like the proposed paragraph if we replaced "virtual memory
> > >> map" with "page table mappings", or do you object to the entirety of the
> > >> new suggestion?
> > >
> > > I object to the suggestion in general. The description is fine as it is.
> >
> > Ok. I'm raising a flag because I had more questions after reading the
> > docstring than before.
>
> Sure and so I think this is valuable information, and indicates it's
> probably worthwhile adding a little extra information on mentioning page
> tables.

Sorry, I'm a bit lost. What would you like me to add? Perhaps there's
an existing file in Documentation/ that I can link to?

Alice