linux-kernel - Re: [PATCH v2 3/3] padata: avoid UAF for reorder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7b912100-3504-4d9d-a94a-d45f98aee00c@huawei.com>
Date: Tue, 14 Jan 2025 20:22:13 +0800
From: chenridong <chenridong@...wei.com>
To: Daniel Jordan <daniel.m.jordan@...cle.com>, Chen Ridong
	<chenridong@...weicloud.com>
CC: <steffen.klassert@...unet.com>, <herbert@...dor.apana.org.au>,
	<nstange@...e.de>, <linux-crypto@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <wangweiyang2@...wei.com>
Subject: Re: [PATCH v2 3/3] padata: avoid UAF for reorder_work



On 2025/1/14 1:00, Daniel Jordan wrote:
> On Fri, Jan 10, 2025 at 06:16:39AM +0000, Chen Ridong wrote:
> ...
>> Fixes: bbefa1dd6a6d ("crypto: pcrypt - Avoid deadlock by using per-instance padata queues")
>> Signed-off-by: Chen Ridong <chenridong@...wei.com>
> 
> Series looks good, thanks for the persistence.
> 

Thank you for your patience.

Best regards,
Ridong
> Acked-by: Daniel Jordan <daniel.m.jordan@...cle.com>
> 
>> diff --git a/kernel/padata.c b/kernel/padata.c
> ...
>>  static void invoke_padata_reorder(struct work_struct *work)
>> @@ -364,6 +370,8 @@ static void invoke_padata_reorder(struct work_struct *work)
>>  	pd = container_of(work, struct parallel_data, reorder_work);
>>  	padata_reorder(pd);
>>  	local_bh_enable();
>> +	/* Pairs with putting the reorder_work in the serial_wq */
> 
> s/putting/getting/
>