linux-kernel - Re: [PATCH v2 RESEND] x86/kaslr: Ingest nokaslr to avoid passing it to init process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250114123142.GCZ4ZZLiIBm2cMg9ny@fat_crate.local>
Date: Tue, 14 Jan 2025 13:31:42 +0100
From: Borislav Petkov <bp@...en8.de>
To: Peter Zijlstra <peterz@...radead.org>
Cc: Nir Lichtman <nir_lichtman@...mail.com>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
	"luto@...nel.org" <luto@...nel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"m.younesbadr@...il.com" <m.younesbadr@...il.com>,
	Nir Lichtman <nir@...htman.org>
Subject: Re: [PATCH v2 RESEND] x86/kaslr: Ingest nokaslr to avoid passing it
 to init process

On Tue, Jan 14, 2025 at 10:36:43AM +0100, Peter Zijlstra wrote:
> On Sat, Jan 11, 2025 at 02:17:43PM +0000, Nir Lichtman wrote:
> > Problem: Currently booting the kernel with "nokaslr" on x86 incorrectly
> > doesn't recognize this parameter and passes it on to the init process
> 
> What now? I'm pretty sure nokaslr works, it's in all my test machines
> and qemu scripts. Without it faddr2line wouldn't work, which I would
> notice in a hurry.

Yeah, the param itself works - he doesn't want to pass it on to the init
process because then it says:

[    0.073613] Unknown kernel command line parameters "nokaslr", will be passed to user space.

due to our detection of which parameters got eaten and which didn't.

I'm still "meh" on this thing...

Frankly, I'd prefer if print_unknown_bootoptions() actually did it all itself,
without spreading out silly code which is only to shut up a warning...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette